[patch] - bbsplash

[Michele Sanges]

Il giorno sab, 01/03/2008 alle 22.08 +0100, Denys Vlasenko ha scritto:

> Somebody said it works for them, but slowly.
> Let's take a look.

<cut>

> Please speed up "filled rectangle" function similarly.

I change the code for 'fb_drawfullrectangle' function in a similar way,
but I think that isn't slow the drawing of the progress bar, but it's
slow the initial drawing of the image. 
Probably the ppm format is not exactly the most suitable because it's
not compressed and so too big.

Christian, can you confirm this?

In the future I would like manage other images formats.


>         pinifile = xfopen("/etc/bbsplash/bbsplash.ini", "r");
> 
> Can this be a command line switch?
> "bbsplash -i <inifile> -f <fifo> -d <device>" etc...

Ok, I add this options.


>         sprintf(G.strsplash_theme, "/etc/bbsplash/%s", pvalue);
> 
> Use char *str  instead of char str[FIXED_SIZE] for it, and do
> 
>         G.strsplash_theme = xasprintf(...);
> 
> This way you use as much memory as needed, and don't have artificial
> size limit.

Ok

> I rebased the patch to current svn, please see it attached.
> fb_drawrectangle() is edited, the rest is not touched
> (except for s/PTR_TO_GLOBALS/SET_PTR_TO_GLOBALS/).
> 
> You can download current svn and base your work on it
> using this command:
> 
> svn co svn://busybox.net/trunk/busybox

I'm behind a firewall that does not allow to contact the svn port. I
will base the work on the latest daily snapshot.

Regards.
Michele