[patch] fbsplash

[Michele Sanges]

Patch for the today tarball.

> [line 387]
> if (fifo_filename)
> 	fp = xfopen_stdin(fifo_filename);

'xfopen_stdin' blocks on open so, using the fifo it isn't showed any
image until the first command is received.
I modified it and the old way of parsing the commands.


> Il giorno mer, 26/03/2008 alle 14.58 +0100, Bernhard Fischer ha scritto:
> > >+USE_FBSPLASH(APPLET(fbsplash, _BB_DIR_BIN, _BB_SUID_NEVER))
> > 
> > Perhaps it would make more sense to put this into /sbin ?

Done.

> As said previously, it may be benefical to pass a pointer to struct
> geometry to the drawing functions instead of passing x/y and
> eventually
> r/g/b/a as individual parameters.

The geometry struct is global so it isn't necessary to pass the pointer
to it --> I removed any parameters to the function 'fb_drawrectangle'.

For the function 'fb_drawfullrectangle', called several times with
runtime variable parameters (in order to shows different lenghts of the
progress bar), I don't know whether it is convenient create a special
structure for this function.

Denys, can you try this patch and, if it is correct, add it to svn.

Thanks.
Michele


-------------- next part --------------
A non-text attachment was scrubbed...
Name: fbsplash_28_03.diff
Type: text/x-patch
Size: 6694 bytes
Desc: not available
Url : http://busybox.net/lists/busybox/attachments/20080328/7cc0edc9/attachment.bin