[patch] fbsplash

[Denys Vlasenko]

On Friday 28 March 2008 11:25, Michele Sanges wrote:
> Patch for the today tarball.
> 
> > [line 387]
> > if (fifo_filename)
> > 	fp = xfopen_stdin(fifo_filename);
> 
> 'xfopen_stdin' blocks on open so, using the fifo it isn't showed any
> image until the first command is received.
> I modified it and the old way of parsing the commands.

Old way of parsing commands has two bugs, and thus is not acceptable.

1. { echo 11; echo 88; } | { sleep 1; fbsplash -f - ...; }
   will display 11% bar, not 88%.
   (actually, it will not work at all, because you killed
   "dash means stdin" feature...
2. It will hog CPU on EOF, as I explained and had shown with example.

> Denys, can you try this patch and, if it is correct, add it to svn.

Applied apart from the part which you can see in attachment. Thanks.
--
vda
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2.patch
Type: text/x-diff
Size: 2786 bytes
Desc: not available
Url : http://busybox.net/lists/busybox/attachments/20080328/a6338d51/attachment.patch