[patch] 1.10.2: compiler warnings when building for i386 arch

[Cristian Ionescu-Idbohrn]

On Fri, 9 May 2008, Denys Vlasenko wrote:

> Applied except for get_terminal_width_height - I guess
> it makes more sense to fix the function to take (unsigned*)
> params.

Right.

> BTW: do you pass additional -Wsomething to the build?
> It makes sense to add it permanently to build system,
> this will prevent people from introducing these warnings again.

This comes from -Wall (see attached).

Ran that and a few other individual -Wsomething an hour or so ago.
Attached those too.


Cheers,

-- 
Cristian
-------------- next part --------------
archival/libunarchive/get_header_tar.c: In function 'get_header_tar':
archival/libunarchive/get_header_tar.c:148: warning: comparison is always false due to limited range of data type
coreutils/ls.c: In function 'ls_main':
coreutils/ls.c:812: warning: pointer targets in passing argument 2 of 'get_terminal_width_height' differ in signedness
coreutils/md5_sha1_sum.c: In function 'hash_bin_to_hex':
coreutils/md5_sha1_sum.c:24: warning: pointer targets in return differ in signedness
coreutils/stty.c: In function 'display_window_size':
coreutils/stty.c:764: warning: pointer targets in passing argument 2 of 'get_terminal_width_height' differ in signedness
coreutils/stty.c:764: warning: pointer targets in passing argument 3 of 'get_terminal_width_height' differ in signedness
coreutils/stty.c: In function 'stty_main':
coreutils/stty.c:1317: warning: pointer targets in passing argument 2 of 'get_terminal_width_height' differ in signedness
coreutils/tr.c: In function 'tr_main':
coreutils/tr.c:211: warning: pointer targets in passing argument 2 of 'expand' differ in signedness
coreutils/tr.c:212: warning: pointer targets in passing argument 2 of 'map' differ in signedness
libbb/appletlib.c: In function 'unpack_usage_messages':
libbb/appletlib.c:77: warning: pointer targets in passing argument 3 of 'start_bunzip' differ in signedness
miscutils/eject.c: In function 'eject_scsi':
miscutils/eject.c:60: warning: pointer targets in assignment differ in signedness
miscutils/less.c: In function 'less_getch':
miscutils/less.c:734: warning: pointer targets in passing argument 1 of 'getch_nowait' differ in signedness
miscutils/less.c: In function 'less_main':
miscutils/less.c:1383: warning: pointer targets in passing argument 2 of 'get_terminal_width_height' differ in signedness
miscutils/less.c:1383: warning: pointer targets in passing argument 3 of 'get_terminal_width_height' differ in signedness
networking/arp.c: In function 'arp_getdevhw':
networking/arp.c:203: warning: pointer targets in passing argument 1 of 'xhw->print' differ in signedness
In file included from networking/nc.c:13:
networking/nc_bloaty.c: In function 'dolisten':
networking/nc_bloaty.c:379: warning: pointer targets in passing argument 5 of 'getsockopt' differ in signedness
networking/nc_bloaty.c: In function 'oprint':
networking/nc_bloaty.c:490: warning: pointer targets in passing argument 1 of 'sprintf' differ in signedness
networking/nc_bloaty.c: In function 'readwrite':
networking/nc_bloaty.c:631: warning: pointer targets in passing argument 2 of 'oprint' differ in signedness
networking/nc_bloaty.c:646: warning: pointer targets in passing argument 2 of 'oprint' differ in signedness
networking/sendmail.c: In function 'sendgetmail_main':
networking/sendmail.c:536: warning: pointer targets in passing argument 1 of 'bin2hex' differ in signedness
networking/udhcp/files.c: In function 'attach_option':
networking/udhcp/files.c:96: warning: pointer targets in assignment differ in signedness
networking/udhcp/files.c:126: warning: pointer targets in assignment differ in signedness
procps/ps.c: In function 'ps_main':
procps/ps.c:468: warning: pointer targets in passing argument 2 of 'get_terminal_width_height' differ in signedness
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bb-Wsomething.tar.bz2
Type: application/octet-stream
Size: 11943 bytes
Desc: 
Url : http://busybox.net/lists/busybox/attachments/20080509/2c72ff56/attachment.obj