[patch] 1.11.0.svn: compiler warnings when building for i386 arch

Cristian Ionescu-Idbohrn cristian.ionescu-idbohrn at axis.com
Fri May 9 14:42:33 PDT 2008


On Fri, 9 May 2008, Cristian Ionescu-Idbohrn wrote:

> On Fri, 9 May 2008, Denys Vlasenko wrote:
>
> > BTW: do you pass additional -Wsomething to the build?
> > It makes sense to add it permanently to build system,
> > this will prevent people from introducing these warnings again.
>
> This comes from -Wall (see attached).

Catched a few more (attached).  Please review.

Some still lurcking around.  The big chunk are the
get_terminal_width_height related along whith these two:

archival/libunarchive/get_header_tar.c: In function 'get_header_tar':
archival/libunarchive/get_header_tar.c:148: warning: comparison is always
false due to limited range of data type

libbb/appletlib.c: In function 'unpack_usage_messages':
libbb/appletlib.c:77: warning: pointer targets in passing argument 3 of
'start_bunzip' differ in signedness


Cheers,

-- 
Cristian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: more-Wall-warnings.patch
Type: text/x-diff
Size: 2995 bytes
Desc: 
Url : http://busybox.net/lists/busybox/attachments/20080509/bf8af251/attachment-0001.patch 


More information about the busybox mailing list