[uClibc] fpclassify fix
Erik Andersen
andersen at codepoet.org
Mon Sep 1 15:02:01 UTC 2003
On Tue Aug 26, 2003 at 06:56:48PM +0900, Atsushi Nemoto wrote:
> I found math fpclassify function is broken because FP_XXX definitions
> in libm/fp_private.h is incompatible with include/math.h.
>
> Also I noticed fp_private.h and fpmacros.c use many 'long int' for
> 32bit variables. I think these should be int or u_int32_t.
>
> Here is a patch against 0.9.20.
>
> fp_private.c:
> --- fix union members (use u_int32_t instead of 'unsigned long int').
> --- remove incompatible FP_XXX definitions (and some unused macros).
> fpmacros.c:
> --- use FP_NAN instead of FP_QNAN/FP_SNAN.
> --- use correct type (int instead of long int).
> --- fix union members (use u_int32_t instead of 'unsigned long int').
> --- remove unnecessary cast.
>
> Note that I had to remove weak_alias for isnanl,isinfl to compile
> patched fpmacroc.c. Is this really needed? Original behavior (using
> isnan for isnanl) seems problematic anyway.
Your patch looks fine. Applied.
-Erik
--
Erik B. Andersen http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--
More information about the uClibc
mailing list