[BusyBox] rdate: Use read and not safe_read [PATCH]
Shaun Jackman
sjackman at gmail.com
Sun Mar 20 02:31:16 UTC 2005
On Sat, 19 Mar 2005 21:03:59 +0100, Rainer Weikusat
<rainer.weikusat at sncag.com> wrote:
> Shaun Jackman <sjackman at gmail.com> writes:
> > I'm not sure why safe_read was used, since the intention was for the
> > alarm to interrupt the read, which safe_read prevents.
>
> Because the signal handler aborts the program
> ('bb_error_message_and_die'). This is an error, because the function
> is not async-signal-safe, but that's another issue.
Thanks for the detailed reply. You mention bb_error_message_and_die is
not async signal safe. What constitutes an async signal safe function?
It seems to me there's "something" wrong with the way the alarm is
handled here, even if I didn't get the patch right. Can you suggest a
fix?
Cheers,
Shaun
More information about the busybox
mailing list