[BusyBox] Re: ifconfig: Clean up. [PATCH]

Shaun Jackman sjackman at gmail.com
Tue Jul 26 06:16:28 UTC 2005


On 7/25/05, Rob Landley <rob at landley.net> wrote:
> > > From busybox/docs/style-guide.txt:
> > > Brackets Are Your Friends

<pedantic> These {} are braces, these [] are brackets, and these ()
are parentheses. </pedantic>

> > Wow.  That sucks deeply.  I hadn't seen that before...

ACK

[clip]
> But this:
> 
> if (thing)
>   do_something();
> 
> Might as well be this:
> 
> if (thing) {
>   do_something();
> }
> 
> And that I have no problem with.

The latter does take one more line than the former, and I agree with Tito:
> So more code fits on one screen [...] and more code you can see at one time better
> you can understand it

<tounge-in-cheek> Lines-of-code are a finite resource, and if we waste
them on lines containing a single brace, we'll have fewer left for the
important tasks, like finding out what *is* past that null pointer.
</tic>

Cheers,
Shaun



More information about the busybox mailing list