[BusyBox] Re: ifconfig: Clean up. [PATCH]

Rob Landley rob at landley.net
Tue Jul 26 09:46:18 UTC 2005


On Tuesday 26 July 2005 01:16, Shaun Jackman wrote:

> > But this:
> >
> > if (thing)
> >   do_something();
> >
> > Might as well be this:
> >
> > if (thing) {
> >   do_something();
> > }
> >
> > And that I have no problem with.
>
> The latter does take one more line than the former, and I agree with Tito:
> > So more code fits on one screen [...] and more code you can see at one
> > time better you can understand it
>
> <tounge-in-cheek> Lines-of-code are a finite resource, and if we waste
> them on lines containing a single brace, we'll have fewer left for the
> important tasks, like finding out what *is* past that null pointer.
> </tic>

I just mean it's something I can live with.  I've seen ugly code in all sorts 
of styles, and a style guide is no substitution for people willing to do 
cleanup passes...

> Cheers,
> Shaun

Rob



More information about the busybox mailing list