[PATCH] modprobe and multiple options to modules

[Rob Landley]

On Monday 03 October 2005 10:11, Yann E. MORIN wrote:
> This patch adds a HUGE amount of code, but hopefully should allow to
> have a common ground to parse arguments with a single function, whether
> it is called from a shell interpreter, or from any other application
> needing argument parsing. Rob, was it what you wanted?

You're right the patch is biggish, I need a little more time than I've got 
right now to go over it properly.  (Hopefully later tonight.)  A quick glance 
looks vaguely sane, although I've seen a couple potential places to tighten 
it up already.  I think we can use this...

Query: right at the start you're checking NULL.  Are we ever going to call it 
with a NULL?  (This could be a "don't do that then" condition...)

> For Intel x86 (P4), it adds 562 bytes:
>    text    data     bss     dec     hex filename
>    3728      20      28    3776     ec0 modprobe.o-orig
>    4290      20      28    4338    10f2 modprobe.o
>
> For ARM Xscale (IXP425), it adds 684:
>    text    data     bss     dec     hex filename
>    4676      20      28    4724    1274 modprobe.o-orig
>    5360      20      28    5408    1520 modprobe.o

That's reasonable for this functionality, but big enough that modprobe might 
need a config option to support this...

> Regards,
> Yann E. MORIN.

Rob