[PATCH] modprobe and multiple options to modules

[Yann E. MORIN]

Hi all!
Rob,

On Tuesday 04 October 2005 072, Rob Landley wrote:
> You're right the patch is biggish, I need a little more time than I've got 
> right now to go over it properly.  (Hopefully later tonight.)  A quick glance 
> looks vaguely sane, although I've seen a couple potential places to tighten 
> it up already.  I think we can use this...

Good, if a few or more bytes can be reclaimed!

> Query: right at the start you're checking NULL.  Are we ever going to call it 
> with a NULL?  (This could be a "don't do that then" condition...)

Well, I use that in mod_process below, in the while loop. Agreed we could save
the bytes for the check, but my habits made me do the check... :-) In that
case, I should handle the loop another way, but I thought it would be more
compact that way.

> > For Intel x86 (P4), it adds 562 bytes:
> > For ARM Xscale (IXP425), it adds 684:
> That's reasonable for this functionality, but big enough that modprobe might 
> need a config option to support this...

Done. It is CONFIG_MODPROBE_MULTIPLE_OPTIONS, depending on CONFIG_MODPROBE.
The resulting code is uggly to me. Is there a better way to do that? Any way,
if CONFIG_MODPROBE_MULTIPLE_OPTIONS is not selected, the previous code is
retained, which means only one option can be passed to a module.

A few quirks mended as well.

This patch is still against 1.01, and supersedes my previous patches on the
matter.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software  Designer | \ / CAMPAIGN     |   ^                |
| --==< °_° >==-- °---.----------------:  X  AGAINST      |  /e\  There is no  |
| web: ymorin.free.fr | SETI at home 3808 | / \ HTML MAIL    |  """  conspiracy.  |
°---------------------°----------------°------------------°--------------------°
-------------- next part --------------
A non-text attachment was scrubbed...
Name: busybox-1.01-modprobe.patch.bz2
Type: application/x-bzip2
Size: 3016 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20051004/83a7f2dc/attachment.bin