udhcp and busybox

Rob Landley rob at landley.net
Fri Mar 24 18:02:56 PST 2006


On Thursday 23 March 2006 10:39 pm, Mike Frysinger wrote:
> On Thursday 23 March 2006 22:25, Rob Landley wrote:
> > On Thursday 23 March 2006 7:00 pm, Mike Frysinger wrote:
> > > Fetching external item into 'networking/udhcp'
> > > Skipped '.'
> >
> > Yeah, my parsing there was really dumb.  But it's just making me love
> > this situation I inherited all the more.
>
> seems relative paths just arent doable
>
> try now

Nope, still doesn't work.

A pity, now that I've started looking at this code, I have some rather 
extensive cleanups to make.  For example, it's not using bb_getopt_ulflags() 
at all, either for the short arguments or for the long arguments.  It's 
including way too many local header files (no 5k busybox app should include 
_nine_ local header files and be spread across four .c files, plus all the 
five files of common code that should either be eliminated or moved to libbb 
or up into the main networking directory.  In lots of places it's using char 
where a bit in "int flags" would do, and the logic to examine a byte is the 
same size as the logic to examine a bit on lots of platforms.

I suppose I'll just have to check my cleaned up version into the networking 
directory and adjust stuff to build it from there.  Luckily, the end result 
should be just one .c file, not a dozen random pieces...

> -mike

Rob
-- 
Never bet against the cheap plastic solution.



More information about the busybox mailing list