[RFC] Updating busybox config/build system to match current kernel system

Sam Ravnborg sam at ravnborg.org
Sat Sep 2 20:22:47 UTC 2006


On Thu, Aug 31, 2006 at 07:20:41PM +0200, Denis Vlasenko wrote:
> [resend to list]
> 
> On Tuesday 29 August 2006 20:40, Rob Landley wrote:
> > > ~300K compressed patch is sort of too big for mailing list.
> > 
> > Ouch.
> > 
> > Can you put it at a URL?
> 
> Yes. Done. http://busybox.net/~vda/
> 
> I tried to replace our current makefiles and config system.
> 
> I am intimidated by deep Makefile wizardry,
> and therefore I cowardly took kernel's one instead of fixing the one
> which we have now.
> 
> I think that it is not likely for kernel system to stop changing,
> so I resisted the desire to remove parts of it which are not needed
> for busybox. I would rather keep it as little changed as possible
> (re
> 
> The patchset is the one which I consider more-or-less
> usable. At least it seems to build allyesconfig and allnoconfig.
> 
> 1.patch - remove Makefile[.in], add Kbuild, tweak Config.in
>           in every directory
> 2.patch - small fixes
> 3.patch - small fixes
> 4.patch - delete old build system & scripts, add new one
> 5.patch - small fix
> 6.patch - (try to) add back make targets like "sizes" etc.
> 7.patch - fix dependency on BB_BT. make was rebuilding everything
>           each time.

Hi Denis.

I took a quick look at your patchset.
And I most say that you are IMO copying too much from the kernel.
fixdep.c is OK
scripts/* is mostly OK.
But to base it on the top-level Makefile for the kernel is not good.
That one is too messy.

How about that I factor out the primary kbuild specific stuff to
scripts/Kbuild.toplevel and you take only that file and implement your
own stuff in current busybox top-level makefile.

Also I notes that you took scripts/Makefile.build verbatim.
That file contains a lot of kernel cruft and you would be in a much
better position using scripts/Kbuild.klibc from klibc.

It more complete and simpler.

If you decide to try to follow these guidelines then I suggest you
to make a more finegrained patch-set. It was not easy to follow
with so many things mixed.

	Sam



More information about the busybox mailing list